feat(phonebook): use modular association groupements #759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #759 +/- ##
==========================================
+ Coverage 85.81% 85.89% +0.08%
==========================================
Files 177 177
Lines 12134 12183 +49
==========================================
+ Hits 10413 10465 +52
+ Misses 1721 1718 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
armanddidierjean
approved these changes
Jun 26, 2025
armanddidierjean
changed the title
Comment on lines
72
to
80
| async def get_all_kinds( | ||
| user: models_users.CoreUser = Depends(is_user_an_ecl_member), | ||
| db: AsyncSession = Depends(get_db), | ||
| ): | ||
| """ | ||
| Return all available kinds of from Kinds enum. | ||
| """ | ||
| kinds = await cruds_phonebook.get_all_kinds() | ||
| return schemas_phonebook.KindsReturn(kinds=kinds) | ||
| return await cruds_phonebook.get_all_groupements(db) |
There was a problem hiding this comment.
Consider replacing both occurrences of kinds
Rotheem
force-pushed
the
PROXI-54-modular-association-groupements
branch
from
833474f to
df6d05e
Compare
Rotheem
force-pushed
the
PROXI-54-modular-association-groupements
branch
from
df6d05e to
b3a027c
Compare
Rotheem
force-pushed
the
PROXI-54-modular-association-groupements
branch
from
45b4497 to
dd3b1a5
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you made here.
Checklist